Async streaming extension methods + ConfigureAwaitFalse improvements by FluttercordKN · Pull Request #77 · Knoema/knoema-csharp-driver

FluttercordKN · 2021-05-05T11:37:55Z

No description provided.

AlexPhilippov · 2021-05-12T05:09:47Z

-# Visual Studio 15
-VisualStudioVersion = 15.0.28010.2046
+# Visual Studio Version 16
+VisualStudioVersion = 16.0.31112.23


This probably stops the project opening on old VS versions

AlexPhilippov · 2021-05-12T05:12:38Z

+
+			var result = await instance.GetDataAsync(request).ToListAsync();
+
+			Console.WriteLine(result.Count);


There is no assert. Maybe it's worth adding specific elements and check the expected ts count. No exceptions are good, but it might be not enough.

Async streaming extension methods + ConfigureAwaitFalse improvements

49f6e39

AlexPhilippov reviewed May 12, 2021

View reviewed changes

Provide feedback


		var result = await instance.GetDataAsync(request).ToListAsync();

		Console.WriteLine(result.Count);